Handle Output values in diffs #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
reviewed
Aug 1, 2019
The server-side diff based on a dryRun doesn't understand Pulumi Outputs, so it would cause an error for any update that depended a calculated value. As a workaround, fallback to a client-side diff if a dryRun diff returns an error.
lblackstone
force-pushed
the
lblackstone/handle-output-in-diff
branch
from
60873e8
to
f9ed212
Compare
hausdorff
reviewed
Aug 1, 2019
hausdorff
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server-side diff based on a dryRun doesn't understand Pulumi
Outputs, so it would cause an error for any update that depended
a calculated value.
As a workaround, fallback to a client-side diff if a dryRun diff
returns an error.
Fixes #679