Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dryRun diff behavior by default #686

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Conversation

lblackstone
Copy link
Member

Add an opt-in feature flag called enableDryRun for the server-side
dry run diffing. In the future, this will be the default behavior.

pkg/provider/provider.go Outdated Show resolved Hide resolved
Add an opt-in feature flag called `enableDryRun` for the server-side
dry run diffing. In the future, this will be the default behavior.
@lblackstone lblackstone marked this pull request as ready for review August 2, 2019 00:40
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that uses this flag?

@lblackstone lblackstone merged commit a283378 into master Aug 2, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/opt-in-flag branch August 2, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants