Properly detect readiness for Deployment scaled to 0. #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
approved these changes
Aug 2, 2019
Previously, the provider would incorrectly flag a Deployment as unready if the replicas spec was set to 0.
lblackstone
force-pushed
the
lblackstone/deploy-scale-to-0
branch
from
4469be0
to
8c2495d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the provider would incorrectly flag a Deployment
as unready if the replicas spec was set to 0.
Partial fix for #605 -- Still need to fix Service that references a Deployment scaled to 0