Handle string values in the equalNumbers function #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equalNumbers function wasn't expecting string inputs, and would panic if one was present. This condition is possible if one of the values is unknown during preview.
|
@hausdorff @pgavlin I wasn't able to reproduce the original issue, but this change should prevent the panic that was reported: |
pgavlin
requested changes
Aug 5, 2019
hausdorff
approved these changes
Aug 5, 2019
Co-Authored-By: Pat Gavlin <pat@pulumi.com>
lblackstone
force-pushed
the
lblackstone/equal-number-fix
branch
from
90dd17a
to
1bf3035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equalNumbers function wasn't expecting string inputs,
and would panic if one was present. This condition is
possible if one of the values is unknown during preview.