Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document await timeouts and how to override #718

Merged
merged 7 commits into from
Aug 20, 2019

Conversation

lblackstone
Copy link
Member

Fixes #714

pkg/gen/awaitComments.go Outdated Show resolved Hide resolved
pkg/gen/awaitComments.go Outdated Show resolved Hide resolved
pkg/gen/awaitComments.go Outdated Show resolved Hide resolved
pkg/gen/awaitComments.go Outdated Show resolved Hide resolved
- Reference the timeout const in the comments
to ensure that they stay synched
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pulling behavior changes into a separate PR, so
this change is just docs now
@lblackstone lblackstone merged commit 4049aea into master Aug 20, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/doc-timeouts branch August 20, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document await timeout defaults
2 participants