Document status of Job readiness check #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
added
the
impact/no-changelog-required
metral
reviewed
Aug 20, 2019
| @@ -107,7 +114,7 @@ Or (for Jobs): The Pod succeeded ('.status.phase' set to "Succeeded"). | |||
| 2. The value of '.status.updateRevision' matches '.status.currentRevision'. | |||
| ` | |||
| default: | |||
| panic("unhandled kind: timeoutValues") | |||
| panic("comments: unhandled kind") | |||
There was a problem hiding this comment.
Are we sure we want to panic here? It seems like an error is a better approach.
There was a problem hiding this comment.
It's just the generator code that runs at build time, so panic is fine here.
metral
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #633