Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and update the docs of the repo for 1.0 #736

Merged
merged 7 commits into from
Aug 23, 2019
Merged

Refactor and update the docs of the repo for 1.0 #736

merged 7 commits into from
Aug 23, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Aug 22, 2019

Closes #727

@metral metral added area/docs Improvements or additions to documentation docs/hackathon labels Aug 22, 2019
@metral metral force-pushed the metral/refactor-1.0 branch 2 times, most recently from ac54ac0 to a9ec04b Compare August 22, 2019 23:21
lblackstone
lblackstone approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

bermudezmt
bermudezmt approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@bermudezmt bermudezmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a few nits and link changes once we land the TOC PR.

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@metral metral merged commit d2e7f5f into master Aug 23, 2019
@pulumi-bot pulumi-bot deleted the metral/refactor-1.0 branch August 23, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp left review comments

@bermudezmt bermudezmt bermudezmt approved these changes

@lblackstone lblackstone lblackstone approved these changes

@lukehoban lukehoban Awaiting requested review from lukehoban

Assignees
No one assigned
Labels
area/docs Improvements or additions to documentation docs/hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor and update the docs, and settings of the repo for 1.0
4 participants
@metral @justinvp @bermudezmt @lblackstone