Improve apiVersion deprecation comments #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/deprecation-warnings
branch
from
5ed035b
to
6895492
Compare
Replace the deprecation comments in the SDKs with more relevant information, and emit warnings when resources are created using deprecated apiVersions.
lblackstone
force-pushed
the
lblackstone/deprecation-warnings
branch
from
6895492
to
0d642a9
Compare
metral
approved these changes
Aug 31, 2019
|
@lukehoban @hausdorff Any feedback on this change, particularly the warnings on the CLI? Since 1.16 is releasing soon, I'd like to get this merged ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace the deprecation comments in the SDKs with more
relevant information, and emit warnings when resources
are created using deprecated apiVersions.
Here's an example of the CLI output:
Related issues (optional)
Fix #660