Aggregate error messages from Pods on Job Read

CHANGELOG.md

@@ -6,6 +6,10 @@
 - v1.15.x
 - v1.14.x
 
+### Improvements
+
+-   Aggregate error messages from Pods on Job Read. (https://github.com/pulumi/pulumi-kubernetes/pull/831).
+
 ## 1.2.0 (October 4, 2019)
 
 ### Supported Kubernetes versions

pkg/await/batch_job.go → pkg/await/job.go

@@ -165,9 +165,19 @@ func (jia *jobInitAwaiter) Read() error {
 		return nil
 	}
 
+	podAggregator, err := NewPodAggregator(ResourceIdFromUnstructured(jia.job), jia.config.clientSet)
+	if err != nil {
+		return errors.Wrapf(err, "Could not create PodAggregator for %s", jia.resource.GVKString())
+	}
+	messages := podAggregator.Read()
+	for _, message := range messages {
+		jia.errors.Add(message)
+		jia.config.logMessage(message)
+	}
+
 	return &initializationError{
 		subErrors: jia.errorMessages(),
-		object: job,
+		object:    job,
 	}
 }
 

pkg/await/watchers.go

@@ -119,6 +119,35 @@ func (pa *PodAggregator) run() {
 	}
 }
 
+// Read lists existing Pods and returns any related warning/error messages.
+func (pa *PodAggregator) Read() logging.Messages {
+	var messages logging.Messages
+	checkPod := func(object runtime.Object) {
+		pod, err := clients.PodFromUnstructured(object.(*unstructured.Unstructured))
+		if err != nil {
+			glog.V(3).Infof("Failed to unmarshal Pod event: %v", err)
+			return
+		}
+		if relatedResource(pa.owner, pod) {
+			messages = append(messages, pa.checker.Update(pod).MessagesWithSeverity(diag.Warning, diag.Error)...)
+		}
+	}
+
+	// Get existing Pods.
+	pods, err := pa.client.List(metav1.ListOptions{})
+	if err != nil {
+		glog.V(3).Infof("Failed to list existing Pods: %v", err)
+	} else {
+		// Log errors and move on.
+		_ = pods.EachListItem(func(object runtime.Object) error {
+			checkPod(object)
+			return nil
+		})
+	}
+
+	return messages
+}
+
 // Stop safely stops a PodAggregator and underlying watch client.
 func (pa *PodAggregator) Stop() {
 	pa.Lock()