Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intermediate status for Jobs #832

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

lblackstone
Copy link
Member

Proposed changes

As part of the normal Pod creation process, they will have unready containers
with a status of "containers with unready status". Since this warning isn't
actionable, only print it if the Job failed to become ready, and not as
part of the intermediate status for the Job.

Before/after:

[0/2] Waiting for Job "foo" to start
[1/2] Waiting for Job "foo" to succeed (Active: 1 | Succeeded: 0 | Failed: 0)
warning: [Pod foo-72lk9]: containers with unready status: [pi]
[1/2] Waiting for Job "foo" to succeed (Active: 0 | Succeeded: 1 | Failed: 0)
Job ready
[0/2] Waiting for Job "foo" to start
[1/2] Waiting for Job "foo" to succeed (Active: 1 | Succeeded: 0 | Failed: 0)
[1/2] Waiting for Job "foo" to succeed (Active: 0 | Succeeded: 1 | Failed: 0)
Job ready

Related issues (optional)

Fixes #822

As part of the normal Pod creation process, they will have unready containers
with a status of "containers with unready status". Since this warning isn't
actionable, only print it if the Job failed to become ready, and not as
part of the intermediate status for the Job.
@lblackstone lblackstone force-pushed the lblackstone/improve-job-warnings branch from 3340c39 to 679e877 Compare October 8, 2019 00:31
@lblackstone lblackstone merged commit abeafd5 into master Oct 8, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/improve-job-warnings branch October 8, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Job awaiter error and warning reporting
2 participants