Update args to support either helm 2 or 3 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passed all tests with both helm v2/v3 |
joeduffy
reviewed
Nov 17, 2019
| - curl -LO https://storage.googleapis.com/kubernetes-helm/helm-v2.14.3-linux-amd64.tar.gz | ||
| - tar -xvf helm-v2.14.3-linux-amd64.tar.gz | ||
| - curl -LO https://get.helm.sh/helm-v3.0.0-linux-amd64.tar.gz | ||
| - tar -xvf helm-v3.0.0-linux-amd64.tar.gz |
There was a problem hiding this comment.
Since there's still Helm 2 in the world, should we continue to test both side-by-side for a period of time?
There was a problem hiding this comment.
I think it should be safe to just test v3 for now. v2 support is winding down over the next year, so I wouldn't expect a lot of changes.
I think testing both is more overhead than it's worth for now, but we can reevaluate if we get bug reports later.
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
--namearg is no longer present in helm v3 forhelm template, but--name-templateappears to accomplish the same thing in both versions. Updated thehelm fetchcommand to use that parameter instead, which should work for both.Related issues (optional)
Fixes #797