Kubernetes provider #897
Kubernetes provider #897
Conversation
There was a problem hiding this comment.
LGTM - thanks for catching this.
Just placing the file in the sdk/dotnet folder does seem to match what NodeJS codegen does - though I suspect that's a mistake that was made along the way in the NodeJS codegen - I believe the goal is that all files there are generated from sources in gen/dotnet-template and placed into sdk/dotnet. This includes files that don't need any templating - like logo.png. The writeDotnetClient function takes care of copying everything over.
That said - happy to take this as-is as it gets us the functionality we need and matches NodeJS SDK.
|
Test failure appears to be due to some flakiness with CRDs and refresh that I've seen a few times (but is not consistent). I pushed 2fe9d0f to try to address this. |
Also write file from templates.
Add a provider resource to the .NET SDK