YAML and Helm support in .NET SDK #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
force-pushed
the
mikhailshilkov/yaml-helm
branch
2 times, most recently
from
c4756a0
to
7481ebb
Compare
mikhailshilkov
changed the title
|
This is ready for review |
lblackstone
requested changes
Feb 19, 2020
|
I'm not familiar enough with C# to understand all of this PR, but I didn't see any obvious issues. Since the tests are passing, I think this is probably good enough to ship once the invoke comment is fixed. |
lblackstone
approved these changes
Feb 21, 2020
|
@lukehoban @pgavlin Do you want to have a look before I merge? |
|
Just wanted to let you know that I'm eager for this to be merged in and released :) |
mikhailshilkov
force-pushed
the
mikhailshilkov/yaml-helm
branch
from
e82b6be
to
e494970
Compare
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #957