Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic condition in Pod await logic #998

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Fix panic condition in Pod await logic #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

- Fix aliases for several resource kinds. (https://github.com/pulumi/pulumi-kubernetes/pull/990).
- Fix .NET resources with empty arguments. (https://github.com/pulumi/pulumi-kubernetes/pull/983).
- Fix panic condition in Pod await logic. (https://github.com/pulumi/pulumi-kubernetes/pull/998).

## 1.5.3 (February 11, 2020)

Expand Down
4 changes: 4 additions & 0 deletions pkg/await/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ func (pia *podInitAwaiter) Read() error {
}

func (pia *podInitAwaiter) processPodEvent(event watch.Event) {
if event.Object == nil {
glog.V(3).Infof("received event with nil Object: %#v", event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what circumstances does this occur?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the linked issue, it seemed like it was caused by a network interruption.

return
}
pod, err := clients.PodFromUnstructured(event.Object.(*unstructured.Unstructured))
if err != nil {
glog.V(3).Infof("Failed to unmarshal Pod event: %v", err)
Expand Down