Use yarn.lock instead of package-lock.json #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
requested changes
Nov 7, 2019
Yeah, in fact I'd be a little partial to that too. I am never sure if "npm is dead, long live yarn" or if "yarn is totally over, npm is cool again". (Or "wtf is yarn, just use nom".) I'll make the change. |
chrsmith
force-pushed
the
chrsmith/use-npmn
branch
from
dc3a3c1
to
26dc838
Compare
chrsmith
changed the title
|
@justinvp PTAL, we should be totally into |
ekrengel
approved these changes
Nov 7, 2019
|
@sean1588 Another working agreement item -- we use yarn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI/CD setup I had was using
yarnto get dependencies and things, but we had apackage-lock.jsonchecked into the repo. This PR corrects that.