Integration tests: Use oauth client instead of API token #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guineveresaenger
force-pushed
the
guin/oauth-scopes
branch
from
e436aed
to
816fcdb
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
requested review from
a team and
t0yv0
and removed request for
a team
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce ops toil.
It uses the new oauth client to authenticate against Tailscale.
Due to the client creating short-lived API tokens, this brings us to a final resolution for #93 for this provider.
I have unset the TAILSCALE_API_KEY Action secret, generated a Tailscale Oauth client and added those secrets to the repository.
If the integration test passes on this PR, it means the keys are valid.
Additionally, I added a friendly failfast to our tests to verify if the keys exist. This is an improvement over our previous practice of
t.Skip.h/t to @passcod for the original issue!
Part of #150.