tfgen.convert.Convert panics instead of returning an error

[jkodroff]

The code does the meat of converting HCL panics when it encounters an error, which complicates the code for downstream callers, like tfbridge.convertHCL():

https://github.com/pulumi/pulumi-terraform-bridge/blob/master/pkg/tf2pulumi/convert/tf12.go#L161-L167

If we panic for good reason, we need to document the reasoning in a comment. Otherwise, we should return an error in order to allow downstream callers to handle issues parsing HCL as they see fit.

[stack72]

@jkodroff I think you have changed this behaviour now right?

[jkodroff]

@stack72 No - I have not touched any code in the tf2pulumi package. What I did was wrap the call in tfgen so that that particular call to convert.Convert() catches the panic.

[t0yv0]

@guineveresaenger referenced this issue but I believe tf2pulumi codebase in the bridge is being deprecated in favor of calling pulumi for explicit conversion via pulumi-converter-terraform. I'm not aware that the converter can panic - it probably shouldn't or we just fix it if we find panics. So possibly we can close this as won't fix.