Improve error messages for Invalid or unknown key #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Jan 31, 2024
| @@ -1118,8 +1149,8 @@ func TestCheckConfig(t *testing.T) { | |||
| }) | |||
| require.NoError(t, err) | |||
| require.Equal(t, 1, len(resp.Failures)) | |||
| require.Equal(t, "could not validate provider configuration: "+ | |||
| "Invalid or unknown key. Examine values at 'explicitprovider.requiredprop'.", | |||
| require.Equal(t, "could not validate provider configuration: Invalid or unknown key. "+ | |||
There was a problem hiding this comment.
Accidental edit, disregard, this stays the same. The explicit provider error should be very rare as it should be a compilation error typically in TypeScript.
|
CC @zbuchheit |
zbuchheit
reviewed
Jan 31, 2024
pkg/tfbridge/provider_test.go
Outdated
| "Did you mean `testprovider:configValue`?", | ||
| require.Equal(t, "`testprovider:cofnigValue` is not a valid configuration key for the testprovider provider. "+ | ||
| "Did you mean `testprovider:configValue`? "+ | ||
| "If the key is not intended for the provider, please choose a different namespace from `testprovider:`.", |
There was a problem hiding this comment.
Suggested change
| "If the key is not intended for the provider, please choose a different namespace from `testprovider:`.", | |
| "If the referenced key is not intended for the provider, please choose a different namespace from `testprovider:`.", |
nit: makes it more specific
iwahbe
approved these changes
Feb 1, 2024
t0yv0
force-pushed
the
t0yv0/fix-errmsg
branch
from
bf87c5d
to
87e6869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per pulumi/pulumi#3546 it is possible that when a user specifies
aws:fooconfig in a Pulumi program she is not intending it to be picked up by the aws provider. This change improves the error message emitted in this case to guide the user better.