Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mappings file naming for examples conversion #1675

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Feb 5, 2024

This change is motivated by pulumi/pulumi-azure#1377 - it seems that the correct way to identify a provider to the TF converter is by using the resource prefix. This makes sure "azurerm" is used and not "azure" for the Azure Classic prover for resource conversion, which in turn makes it use the in-flight ProviderInfo and stop trying to download an Azure Classic build from GitHub.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@t0yv0 t0yv0 merged commit b887bc5 into master Feb 5, 2024
7 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-mappings-file-naming branch February 5, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants