Fix azure loader issues #1682
Merged
Fix azure loader issues #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guineveresaenger
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
I was trying to see if we could just call LoadPackage with the correct name but that looks to be not in scope of this repo. Oof.
I presume that the ProviderInfo.Name field has to remain azurerm for pulumi-azure and that renaming that field instead would cause other issues?
Looks good to me, modulo thoughts and one minor nit.
| if g.pluginHost != nil { | ||
| l := newLoader(g.pluginHost) | ||
| // Ensure azurerm resolves to azure for example: | ||
| l.aliasPackage(g.info.Name, string(g.pkg)) |
There was a problem hiding this comment.
nit: g.pkg has a String() method
|
LoadPackage is deep in the stack trace.. A good alternative behavior would be to fail fast when 'unknown_resource' is found in the example that doesn't belong to the known provider. But for now this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1681
For providers such as Azure Classic that have a discrepancy between "azure" and "azurerm", PULUMI_CONVERT=1 conversion no longer attempts to resolve and download the "azurerm" plugin from GitHub.