Raise the default log level of TF from WARN to ERROR #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
commented
Feb 14, 2024
| default: | ||
| return hclog.NoLevel | ||
| } | ||
| return hclog.LevelFromString(os.Getenv(tfLogEnvVar)) |
There was a problem hiding this comment.
This is a simple refactor to use hclog's own switch statement. It doesn't change any behavior.
iwahbe
force-pushed
the
iwahbe/mirror-tf-log-default-level
branch
from
02eea91
to
965dc1a
Compare
guineveresaenger
approved these changes
Feb 15, 2024
iwahbe
force-pushed
the
iwahbe/mirror-tf-log-default-level
branch
from
965dc1a
to
dc98ff7
Compare
|
I'm wondering if TF CLI shows messages emitted even against ERROR level at this API by default, something I neglected to check. If TF CLI does not by default emit or react to them that'd be a good argument for Pulumi as well to only have these logs be opt-in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pulumi/pulumi-aws#3389