Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation for adding bridge-metadata.json #1691

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Feb 21, 2024

This is in response to #1690.

@iwahbe
Copy link
Member Author

iwahbe commented Feb 21, 2024

CC @ringods

@iwahbe iwahbe force-pushed the iwahbe/improve-docs-for-adding-metadata branch from 26a8cc3 to 14e4d67 Compare February 21, 2024 15:04
@iwahbe iwahbe enabled auto-merge (squash) February 21, 2024 15:05
@iwahbe iwahbe disabled auto-merge February 21, 2024 15:13
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a file referenced that doesn't exist (yet)? Please disregard if GitHub is playing tricks on me.

Can we consider consolidating https://github.com/pulumi/pulumi-terraform-bridge/blob/master/pkg/tfbridge/README.md to here perhaps?

docs/metadata.md Show resolved Hide resolved
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwahbe iwahbe merged commit 8e494d6 into master Feb 26, 2024
7 checks passed
@iwahbe iwahbe deleted the iwahbe/improve-docs-for-adding-metadata branch February 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants