Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count all errors in the example coverage tracker #1713

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Feb 27, 2024

There is an anomaly in the stats in pulumi/pulumi-azuread#484 where YAML has fewer examples counted in the denominator than other languages, this should be impossible. Looks like some error handling assumptions do not apply to PULUMI_CONVERT=1 anymore and was swallowing errors.

With this small tweak the errors for the failed examples now show up in the coverage tracker:

warning: failed to convert HCL for #/functions/azuread:index/getDomains:getDomains to yaml: :3,11-43: Failed to generate YAML program: Splat; A 'Splat' expression is equivalent in expressive power to a 'for loop', and is not representable in YAML.
If the values of the function are known, you can manually unroll the loop, otherwise it is necessary to switch to a more expressive language., and 1 other diagnostic(s)

@t0yv0 t0yv0 requested a review from iwahbe February 27, 2024 16:22
@t0yv0 t0yv0 changed the title Count all errors Count all errors in the example coverage tracker Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 59.09%. Comparing base (47fa9ff) to head (80c541f).
Report is 88 commits behind head on master.

Files Patch % Lines
pkg/tfgen/docs.go 25.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
- Coverage   59.54%   59.09%   -0.46%     
==========================================
  Files         295      306      +11     
  Lines       41462    42296     +834     
==========================================
+ Hits        24690    24995     +305     
- Misses      15382    15869     +487     
- Partials     1390     1432      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 merged commit e336d98 into master Feb 27, 2024
9 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-errcounting branch February 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants