Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for cross-testing bridged providers against TF-defined behavior #1728

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 4, 2024

Tests to compare and contrast the behavior of a given Terraform provider under Terraform CLI against the behavior of the
same provider bridged to Pulumi and used under Pulumi CLI.

@t0yv0
Copy link
Member Author

t0yv0 commented Mar 18, 2024

These tests can pass now on v3.111.1 of Pulumi CLI without requiring customized pulumi-yaml and pulumi CLI builds - CC @VenelinMartinov

Looks like we need to upgrade the bridge to latest, and I need to tidy up the PRs here to get them mergeable then we can land an initial version of this and iterate further.

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Mar 19, 2024

FYI I had a go at implementing a cross-test on top of this for #1767 in #1768

Didn't quite work but it looks promising.

@t0yv0 t0yv0 changed the base branch from master to t0yv0/shareable-convert-module March 21, 2024 22:35
@t0yv0 t0yv0 force-pushed the t0yv0/shareable-convert-module branch 2 times, most recently from f3d5508 to 88c5683 Compare March 22, 2024 13:19
Base automatically changed from t0yv0/shareable-convert-module to master March 22, 2024 13:32
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.04%. Comparing base (6083fb1) to head (2d8631d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   60.58%   60.04%   -0.54%     
==========================================
  Files         302      309       +7     
  Lines       42213    42591     +378     
==========================================
  Hits        25574    25574              
- Misses      15168    15547     +379     
+ Partials     1471     1470       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 changed the title TF cross tests Initial setup for cross-testing bridged providers against TF-defined behavior Mar 22, 2024
@t0yv0 t0yv0 marked this pull request as ready for review March 22, 2024 15:26
@VenelinMartinov
Copy link
Contributor

I tried to run this earlier today and hit this issue:

Diagnostics:
          pulumi:pulumi:Stack (project-test):
            Error: error resolving type of resource example: internal error loading package "crossprovider": could not find latest version for provider crossprovider: 404 HTTP error fetching plugin from https://api.github.com/repos/pulumi/pulumi-crossprovider/releases/latest. If this is a private GitHub repository, try providing a token via the GITHUB_TOKEN environment variable. See: https://github.com/settings/tokens
              on Pulumi.yaml line 92:
              92:         type: crossprovider:index:TestRes

I was certainly able to run this before. Is this an issue with my local setup or a regression in the PR?

@t0yv0
Copy link
Member Author

t0yv0 commented Mar 22, 2024

Upgrade your Pulumi CLI on latest.

Looks like these tests fail on some OS-s because TF CLI is not setup in CI. I'll just disable them conditionally on O.S. for now to run only on Linux.

Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@VenelinMartinov VenelinMartinov merged commit d90d762 into master Mar 23, 2024
9 checks passed
@VenelinMartinov VenelinMartinov deleted the t0yv0/cross-tests branch March 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants