-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup for cross-testing bridged providers against TF-defined behavior #1728
Conversation
c7759e1
to
0ab1a5b
Compare
These tests can pass now on v3.111.1 of Pulumi CLI without requiring customized pulumi-yaml and pulumi CLI builds - CC @VenelinMartinov Looks like we need to upgrade the bridge to latest, and I need to tidy up the PRs here to get them mergeable then we can land an initial version of this and iterate further. |
149e8bb
to
98cffdb
Compare
f3d5508
to
88c5683
Compare
af8cf2f
to
254a64b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
- Coverage 60.58% 60.04% -0.54%
==========================================
Files 302 309 +7
Lines 42213 42591 +378
==========================================
Hits 25574 25574
- Misses 15168 15547 +379
+ Partials 1471 1470 -1 ☔ View full report in Codecov by Sentry. |
b813ba4
to
159182e
Compare
I tried to run this earlier today and hit this issue:
I was certainly able to run this before. Is this an issue with my local setup or a regression in the PR? |
Upgrade your Pulumi CLI on latest. Looks like these tests fail on some OS-s because TF CLI is not setup in CI. I'll just disable them conditionally on O.S. for now to run only on Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Tests to compare and contrast the behavior of a given Terraform provider under Terraform CLI against the behavior of the
same provider bridged to Pulumi and used under Pulumi CLI.