Have the downstream check script wait for the sentinel job #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
- Coverage 59.72% 59.21% -0.52%
==========================================
Files 301 308 +7
Lines 42034 42412 +378
==========================================
+ Hits 25104 25113 +9
- Misses 15495 15865 +370
+ Partials 1435 1434 -1 ☔ View full report in Codecov by Sentry. |
t0yv0
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1730
Looks like the
statusCheckRollupparameter could return SUCCESS even if the jobs have yet to run 🥲This should fix it by having the reaper script explicitly check the sentinel job.