Ensure NotYetImplemented warnings are errors #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During HCL->PCL conversion, the converter may emit not-yet-implemented code and warn about it. For the use case in the bridge, it is better to reject such examples completely than warn about them. This changes accomplishes the dropout of affected examples indirectly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1733 +/- ##
==========================================
+ Coverage 59.72% 60.92% +1.20%
==========================================
Files 301 307 +6
Lines 42034 35323 -6711
==========================================
- Hits 25104 21520 -3584
+ Misses 15495 12369 -3126
+ Partials 1435 1434 -1 ☔ View full report in Codecov by Sentry. |
iwahbe
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During HCL->PCL conversion, the converter may emit not-yet-implemented code and warn about it. For the use case in the bridge, it is better to reject such examples completely than warn about them. This changes accomplishes the dropout of affected examples indirectly.
Effect on GCP: pulumi/pulumi-gcp#1787
Effect on Azure: pulumi/pulumi-azure#1829
Effect on AWS: pulumi/pulumi-aws#3576
Fixes #1732