Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a deterministic diff result #1737

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Mar 6, 2024

Fixes #876

This prevented pulumi/pulumi-gcp#1785 from merging.

@iwahbe iwahbe self-assigned this Mar 6, 2024
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"But people might start depending on the order!"
Thanks for fixing - I've had to escape a few diffs in GRPC tests with "*" as well

@VenelinMartinov
Copy link
Contributor

Actually could this have any serious performance implications?

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (f6013b6) to head (2ac2344).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   59.74%   59.21%   -0.53%     
==========================================
  Files         301      308       +7     
  Lines       42034    42416     +382     
==========================================
+ Hits        25112    25116       +4     
- Misses      15488    15866     +378     
  Partials     1434     1434              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe
Copy link
Member Author

iwahbe commented Mar 6, 2024

Actually could this have any serious performance implications?

I'd be very surprised if the number of properties being sorted were large enough to have performance implications. Especially compared to the overhead of serialization, IPC, and network requests.

@iwahbe iwahbe merged commit 400084e into master Mar 6, 2024
9 checks passed
@iwahbe iwahbe deleted the iwahbe/876/deterministic-diff-result branch March 6, 2024 18:56
@t0yv0
Copy link
Member

t0yv0 commented Mar 6, 2024

Probably fine, can't think of why the ordering would matter in prod, but might trip up some overfitting tests. A bit odd to change prod code to make testing easier. But I can see the motivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff.response.stables is returned in a non-deterministic order
3 participants