Add tfgen time validation for ProviderInfo.Resources #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
- Coverage 60.57% 60.07% -0.50%
==========================================
Files 302 310 +8
Lines 42213 42694 +481
==========================================
+ Hits 25569 25649 +80
- Misses 15173 15572 +399
- Partials 1471 1473 +2 ☔ View full report in Codecov by Sentry. |
t0yv0
reviewed
Mar 14, 2024
| var ( | ||
| errNoCoorospondingField = fmt.Errorf("overriding non-existent field") | ||
| errNoElemToOverride = fmt.Errorf("overriding non-existent elem") | ||
| errCannotSpecifyFieldsOnListOrSet = fmt.Errorf("cannot specify .Fields on a List[T] or Set[T] type") |
|
This is very valuable! Would be curious to run downstream checks perhaps we can preemptively fixup non-compliant providers before merging to main. For good form could throw in some tests to cover this code but it's not the top priority for coverage obviously, looks nice and straightforward. |
t0yv0
approved these changes
Mar 14, 2024
iwahbe
force-pushed
the
iwahbe/validate-ProviderInfo.Resources
branch
3 times, most recently
from
bf01cbf
to
4d763c1
Compare
|
I added tests, which caught one set of false negatives. I'm blasting out a test run on downstream now: https://github.com/pulumi/pulumi-terraform-bridge/actions/runs/8438306439. If that returns 🟢 or all failures are genuine, I'll merge. |
iwahbe
force-pushed
the
iwahbe/validate-ProviderInfo.Resources
branch
from
4d763c1
to
cff9ca4
Compare
iwahbe
added a commit
to pulumi/pulumi-datadog
that referenced
this pull request
Mar 27, 2024
This fixes a bug in schema traversal, unblocking pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-cloudflare
that referenced
this pull request
Mar 27, 2024
This is part of releasing pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Mar 27, 2024
This cleanup is necessary as part of releasing pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Mar 27, 2024
This is a breaking change for Go and Typescript if users were reading the `PolicyDocument` field on LogResourcePolicyArgs or on LogResourcePolicy. This was discovered as part of pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Mar 27, 2024
- `aws_cloudwatch_log_resource_policy.policy_document` - `aws_ecr_registry_policy.policy` - `aws_sns_topic_policy.policy` This is a breaking change for Go and Typescript if users were reading the `PolicyDocument` field on LogResourcePolicyArgs or on LogResourcePolicy. This was discovered as part of pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Mar 27, 2024
This is part of releasing pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-cloudflare
that referenced
this pull request
Mar 27, 2024
This is part of releasing pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-datadog
that referenced
this pull request
Mar 27, 2024
This fixes a bug in schema traversal, unblocking pulumi/pulumi-terraform-bridge#1758.
iwahbe
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Mar 28, 2024
…3743) This is a breaking change for Go and Typescript if users were reading the `PolicyDocument` field on LogResourcePolicyArgs or on LogResourcePolicy. If we don't want to take the change, we can remove the override entirely (semantically equivalent to what we have now in master). This was discovered as part of pulumi/pulumi-terraform-bridge#1758.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While discussing #1757, there was some uncertainty on how to align
*SchemaInfowith the underlyingshim.Schema. This PR clarifies by introducing a user error duringmake tfgentime if the user provides a misaligned or nonsensical*SchemaInfo.