Log redirector now respects TF_LOG #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1772 +/- ##
==========================================
- Coverage 59.97% 59.47% -0.50%
==========================================
Files 302 309 +7
Lines 42133 42540 +407
==========================================
+ Hits 25268 25301 +33
- Misses 15437 15813 +376
+ Partials 1428 1426 -2 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Mar 21, 2024
Before this change all logs emitted with `log.Printf` were sent to Pulumi as DEBUG-level logs, making it difficult to detect errors and warnings emitted in this way, or to filter verbose logs to find errors or warnings. The are two changes: - bridged providers will continue to send these logs as DEBUG-level logs by default but will now attach the original level label to the message, so that filtering verbose logs is easier - if the user sets the TF_LOG environment variable to an appropriate value such as TF_LOG=WARN, these logs will be sent to Pulumi at their correct level and will be made visible by Pulumi CLI The TF_LOG-gated behavior matches Terraform behavior where seeing logs in the CLI is opt-in and disabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change all logs emitted with
log.Printfwere sent to Pulumi as DEBUG-level logs, making it difficult to detect errors and warnings emitted in this way, or to filter verbose logs to find errors or warnings.Fixes #1632
The are two changes:
bridged providers will continue to send these logs as DEBUG-level logs by default but will now attach the original level label to the message, so that filtering verbose logs is easier
if the user sets the TF_LOG environment variable to an appropriate value such as TF_LOG=WARN, these logs will be sent to Pulumi at their correct level and will be made visible by Pulumi CLI
The TF_LOG-gated behavior matches Terraform behavior where seeing logs in the CLI is opt-in and disabled by default.