Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test RandomBytes PF support #1777

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Test RandomBytes PF support #1777

merged 1 commit into from
Mar 21, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 21, 2024

Small PR to cover support for resources without a proper ID like RandomBytes. To do this:

Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 59.46%. Comparing base (d744c5d) to head (e68bfb8).

Files Patch % Lines
pf/tests/internal/testprovider/random.go 22.22% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
- Coverage   60.00%   59.46%   -0.54%     
==========================================
  Files         302      309       +7     
  Lines       42162    42558     +396     
==========================================
+ Hits        25299    25308       +9     
- Misses      15437    15823     +386     
- Partials     1426     1427       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 merged commit c5f6262 into master Mar 21, 2024
9 checks passed
@t0yv0 t0yv0 deleted the t0yv0/test-random-bytes branch March 21, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants