Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor computing changed keys for Plugin Framework #1778

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 21, 2024

The slight simplification of the code relaxes some dependencies on the convert module which in turn unlocks simplifying that module.

The slight simplification of the code relaxes some dependencies on the convert module which in turn unlocks simplifying
that module.
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 59.52%. Comparing base (c5f6262) to head (e8d54f8).

Files Patch % Lines
pf/tfbridge/provider_diff.go 56.52% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
- Coverage   59.98%   59.52%   -0.46%     
==========================================
  Files         302      309       +7     
  Lines       42180    42539     +359     
==========================================
+ Hits        25300    25321      +21     
- Misses      15452    15791     +339     
+ Partials     1428     1427       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 merged commit 3a72df8 into master Mar 22, 2024
9 checks passed
@t0yv0 t0yv0 deleted the t0yv0/simplify-diff branch March 22, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants