Fixes issues with name overrides in Plugin Framework invokes #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
- Coverage 60.54% 60.10% -0.45%
==========================================
Files 302 309 +7
Lines 42213 42537 +324
==========================================
+ Hits 25559 25568 +9
- Misses 15182 15498 +316
+ Partials 1472 1471 -1 ☔ View full report in Codecov by Sentry. |
t0yv0
added a commit
that referenced
this pull request
Mar 21, 2024
This enables reuse for cross-tests. On top of [t0yv0/fix-invoke-conversion](#1780)
t0yv0
added a commit
that referenced
this pull request
Mar 21, 2024
This enables reuse for cross-tests. On top of [t0yv0/fix-invoke-conversion](#1780)
VenelinMartinov
approved these changes
Mar 22, 2024
|
Spotted when adding coverage. |
This change fixes an issue where Plugin Framework invokes did not respect SchemaInfo overrides, in particular there could be issues with incorrect translation of incoming PropertyMap data when SchemaInfo specified a different name for a data source property.
t0yv0
force-pushed
the
t0yv0/fix-invoke-conversion
branch
from
91cb6a2
to
dac9730
Compare
t0yv0
added a commit
that referenced
this pull request
Mar 22, 2024
This enables reuse for cross-tests. On top of [t0yv0/fix-invoke-conversion](#1780)
t0yv0
added a commit
that referenced
this pull request
Mar 22, 2024
This enables reuse for cross-tests. On top of [t0yv0/fix-invoke-conversion](#1780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where Plugin Framework invokes did not respect SchemaInfo overrides, in particular there could be issues with incorrect translation of incoming PropertyMap data when SchemaInfo specified a different name for a data source property.
On top of t0yv0/improve-convert-module.