Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cache key more precise #1793

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 26, 2024

Make the examples cache key more precise:

  • do not look at provider version
  • do not look at the entirety of go.mod, only check key package versions
  • include MarshallableProviderInfo in the cache
  • if go.work is used, still include that as before

@t0yv0
Copy link
Member Author

t0yv0 commented Mar 27, 2024

I think I'm getting decent results with this on AWS in pulumi/pulumi-aws#3737

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 60.04%. Comparing base (f64f0d8) to head (769b4be).

Files Patch % Lines
pkg/tfgen/examples_cache.go 67.50% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   60.57%   60.04%   -0.53%     
==========================================
  Files         302      309       +7     
  Lines       42213    42623     +410     
==========================================
+ Hits        25569    25594      +25     
- Misses      15173    15559     +386     
+ Partials     1471     1470       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0yv0 t0yv0 merged commit 86540c9 into master Mar 27, 2024
9 checks passed
@t0yv0 t0yv0 deleted the t0yv0/improve-examples-cache-key branch March 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants