pulumi/pulumi upgrade 3.112.0 #1805
Conversation
VenelinMartinov
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master pulumi/pulumi-terraform-bridge#1805 +/- ##
==========================================
- Coverage 60.60% 60.07% -0.54%
==========================================
Files 303 310 +7
Lines 42348 42726 +378
==========================================
+ Hits 25667 25669 +2
- Misses 15208 15585 +377
+ Partials 1473 1472 -1 ☔ View full report in Codecov by Sentry. |
|
I've kicked off downstream tests, will report back once they finish. EDIT: Everything seems fine, except f5bigip (times out, unrelated) and AWS (still running). I'd like to get this in so I can run another round of downstream tests since there were new commits on master. |
| @@ -119,6 +119,5 @@ func TestFileArchives(t *testing.T) { | |||
| archive.Hash = "" | |||
| file4, err := t1.TranslateArchive(archive) | |||
| assert.Nil(t, err) | |||
| assert.Equal(t, file4.(string), "") | |||
There was a problem hiding this comment.
Can we get an explanation? Very dangerous here.
There was a problem hiding this comment.
I think I dug into this and this is a degenerate case of an archive without a hash and without contents; the AWS bug I am tracking was about an archive with an actual hash but no contents, that doesn't seem to reproduce, but its' really tricky to simulate. Let's not hold off on this. Thanks!
Upgrade the bridge to https://github.com/pulumi/pulumi/releases/tag/v3.112.0
Manual changes:
nodejsgen.GeneratePackageRaised pulumi/pulumi#15852 for the trailing whitespace in the lambda examples