Ensure that asset translation does not clobber the files #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Mar 29, 2024
|
Don't merge before #1814 please |
|
Good to know. Yes we can merge next week, just a regression test. It's fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
- Coverage 60.64% 60.18% -0.47%
==========================================
Files 303 310 +7
Lines 42348 42672 +324
==========================================
Hits 25684 25684
- Misses 15190 15515 +325
+ Partials 1474 1473 -1 ☔ View full report in Codecov by Sentry. |
t0yv0
force-pushed
the
t0yv0/test-archives
branch
from
0dbeeb5
to
9a6dc53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to regress against the situation that caused the AWS P1 in pulumi/pulumi-aws#3622