Remove rawNames from extractInputs and extractSchemaInputs
#1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rawNames` is used to represent the distinction between traversing a Map and a Object. As implemented, it is never correct to respect. The property should never be inherited between functions, since the encoding of `T` does not depend on if `T` is found in `Object<Field: T>` or `Map<T>`. - It is already ignored in `extractSchemaInputs`.
This is a pure refactor of an area already under test. This refactor clarifies the distinction between a map and an object in `extractInputs`.
The value was no longer used, so is safe to remove.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
- Coverage 60.73% 60.20% -0.54%
==========================================
Files 303 310 +7
Lines 42393 42781 +388
==========================================
+ Hits 25749 25755 +6
- Misses 15171 15552 +381
- Partials 1473 1474 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1812.
extractInputsObjectout ofextractInputs, creating an explicit code path for objects.This area is under test in the bridge, making it relatively safe to refactor.