Reduce tfgen failing example warning verbosity #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Apr 4, 2024
pkg/tfgen/convert_cli_test.go
Outdated
| * <nil>: unexpected HCL snippet in Convert "\nThis is some intentionally broken HCL that should not convert.\n{}"; | ||
| * <nil>: unexpected HCL snippet in Convert "\nThis is some intentionally broken HCL that should not convert.\n{}"; | ||
| * <nil>: unexpected HCL snippet in Convert "\nThis is some intentionally broken HCL that should not convert.\n{}"; | ||
| autogold.Expect(`warning: unable to convert HCL example for Pulumi entity '#/resources/azure:webpubsub/customCertificate:CustomCertificate': 1 error occurred: |
There was a problem hiding this comment.
This change demonstrates how stderr is affected.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1843 +/- ##
==========================================
- Coverage 60.91% 60.51% -0.40%
==========================================
Files 303 310 +7
Lines 42431 42822 +391
==========================================
+ Hits 25847 25914 +67
- Misses 15121 15439 +318
- Partials 1463 1469 +6 ☔ View full report in Codecov by Sentry. |
|
Missed handling the partial failure case that's still super duplicative. Adding a few more commits here shortly. |
|
Done now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we emitted a lot of duplicated warnings for examples that failed to convert. This change removes the
duplication and aggregates similar errors so that when every language conversion fails with the same error, which is
common when the failure pertains to the HCL->PCL pass of the conversion, we get one warning only not many.