Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env vars to speed up bisecting tfgen #1848

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 9, 2024

Schema generation takes a long time for large providers like pulumi-aws and adding these helper env vars to limit it to
one problematic resource or data source can be a helpful tool to speed up bisecting over bridge ranges.

Schema generation takes a long time for large providers like pulumi-aws and adding these helper env vars to limit it to
one problematic resource or data source can be a helpful tool to speed up bisecting over bridge ranges.
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 62.32%. Comparing base (22980d5) to head (2713bac).

Files Patch % Lines
pkg/tfgen/docs.go 0.00% 2 Missing and 1 partial ⚠️
pkg/tfgen/examples_cache.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
+ Coverage   61.06%   62.32%   +1.26%     
==========================================
  Files         303      309       +6     
  Lines       42432    35612    -6820     
==========================================
- Hits        25910    22195    -3715     
+ Misses      15053    11947    -3106     
- Partials     1469     1470       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great for quick iteration.

Can you add a reference to this in docs so this is findable for others? Maybe docs/dev#env vars?

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 9, 2024

Sure

@t0yv0 t0yv0 enabled auto-merge (squash) April 9, 2024 19:25
@t0yv0 t0yv0 merged commit 8222ffd into master Apr 9, 2024
10 checks passed
@t0yv0 t0yv0 deleted the t0yv0/targeted-tfgen branch April 9, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants