Refactor MakeTerraformInput tests #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of hardening the bridge, revisit tests for MakeTerraformInput. It turns out that a lot of these tests used schema examples that do not pass InternalValidate that bridged providers should be running at build-time, and therefore these tests do not represent functionality actually used in production. To assist making sure we can write good tests, shim layer is extended to expose SchemaMap.Validate(). Where possible, the test cases were corrected to pass the validation. One exception is map_with_resource_elem test case that is discarded as this is rejected by the validation. Instead, a test case for regular map attributes is added. Several test cases are suspect and may be regression-testing incorrect behavior, NOTE is added for those. Finally, test cases are rearranged into table-driven tests to make them easier to maintain.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1853 +/- ##
==========================================
- Coverage 61.06% 60.46% -0.60%
==========================================
Files 303 310 +7
Lines 42442 42835 +393
==========================================
- Hits 25916 25900 -16
- Misses 15055 15461 +406
- Partials 1471 1474 +3 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of hardening the bridge, revisit tests for MakeTerraformInput.
It turns out that a lot of these tests used schema examples that do not pass InternalValidate that bridged providers should be running at build-time, and therefore these tests do not represent functionality actually used in production.
To assist making sure we can write good tests, shim layer is extended to expose SchemaMap.Validate().
Where possible, the test cases were corrected to pass the validation.
One exception is map_with_resource_elem test case that is discarded as this is rejected by the validation. Instead, a test case for regular map attributes is added.
Several test cases are suspect and may be regression-testing incorrect behavior, NOTE is added for those.
Finally, test cases are rearranged into table-driven tests to make them easier to maintain.