Ensure validate called during tfgen #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 60.48% 60.05% -0.43%
==========================================
Files 310 323 +13
Lines 42835 43894 +1059
==========================================
+ Hits 25908 26360 +452
- Misses 15454 16042 +588
- Partials 1473 1492 +19 ☔ View full report in Codecov by Sentry. |
iwahbe
reviewed
Apr 11, 2024
Co-authored-by: Ian Wahbe <ian@wahbe.com>
Co-authored-by: Ian Wahbe <ian@wahbe.com>
|
Downstream failures: auth0: https://github.com/pulumi/pulumi-auth0/actions/runs/8648328389/job/23711873275?pr=493 - this looks related. Hitting #1816 - these changes cause failures in tfgen which is not picked up by the downstream check script. Will fix that before continuing here. |
|
After fixing #1816 it turns out this caused quite a few downsteam failures: Looking into it, the ones I checked don't look like actual regressions in the schema but rather an issue with the validation logic. EDIT: The issue was that Validate actually requires passing in a valid config and for these providers the empty config is invalid. I've changed tfgen to directly call |
VenelinMartinov
added a commit
that referenced
this pull request
Apr 12, 2024
fixes #1816 Hit it during #1854 It now prints links for the repos which don't have PRs for the commit at all: ``` FAILURE pulumi/pulumi-auth0#493 FAILURE pulumi/pulumi-oci#431 MISSING https://github.com/pulumi/pulumi-opsgenie/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-splunk/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-libvirt/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-minio/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-kafka/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-aws/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-onelogin/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-cloudamqp/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-rabbitmq/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-newrelic/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-dnsimple/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-nomad/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-mailgun/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-mysql/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-sumologic/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-vsphere/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-keycloak/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-slack/actions/workflows/upgrade-bridge.yml MISSING https://github.com/pulumi/pulumi-vault/actions/workflows/upgrade-bridge.yml ```
|
I've kicked off another round of downstream tests from 7d378f7, will report back here once they finish. Everything except auth0, gitlab and aws passed and the first two failed due to master being broken. |
|
pf may use different mechanics for validations so not as relevant in this PR. |
t0yv0
reviewed
Apr 12, 2024
t0yv0
reviewed
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1852
#1669 removed the runtime calls to
InternalValidateto speed up provider startup. This assumed it was called during tfgen but it turns out it was not.This introduces an explicit call to
InternalValidateduring tfgen. Thanks to @t0yv0 for prompting the investigation and @iwahbe for helping with the muxer.To facilitate that, I've added
InternalValidateto the shim Provider interface. Technically breaking but seems unlikely to be depended on externally.Calling
Validatedoes not do the job as that requires passing in a valid config which is not available during tfgen.I've added an e2e test for an sdk provider, need to add one for a pf provider.