Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bisecting failing conversions #1880

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 17, 2024

In the rare case when the bulk example converter panics, the experience of isolating the failing example and reporting a bug does not spark joy. This little change introduces a bisect algo that tries to narrow down an example-set to the one failing example, and also a better error reporting mechanism that prints a repro.sh in a temp folder where the maintainer can inspect further.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 15.21739% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 60.00%. Comparing base (45d8f28) to head (f09c258).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/tfgen/convert_cli.go 15.21% 71 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   60.06%   60.00%   -0.06%     
==========================================
  Files         323      327       +4     
  Lines       43894    43976      +82     
==========================================
+ Hits        26363    26388      +25     
- Misses      16040    16097      +57     
  Partials     1491     1491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A test would be great, but since this doesn't go out to pulumi users I'm fine without.

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

The happy path is under test and the error path I got to use to diagnose pulumi/pulumi-digitalocean#683 issue.

@t0yv0 t0yv0 merged commit d9452a5 into master Apr 18, 2024
11 checks passed
@t0yv0 t0yv0 deleted the t0yv0/improve-converter-failure-diagnostics branch April 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants