Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross tests pretty set printing #1908

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

VenelinMartinov
Copy link
Contributor

This PR adds sets to the pretty printing - they'd print PANIC otherwise.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 60.23%. Comparing base (49a6bff) to head (58ecfb5).

Files Patch % Lines
pkg/tests/cross-tests/pretty.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   60.26%   60.23%   -0.04%     
==========================================
  Files         328      328              
  Lines       44331    44342      +11     
==========================================
- Hits        26717    26710       -7     
- Misses      16118    16135      +17     
- Partials     1496     1497       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, sorry for being in such a rush I left this case for later.

@VenelinMartinov
Copy link
Contributor Author

All good, it was pretty straight-forward to add. Glad you got the whole thing out of the door.

@VenelinMartinov VenelinMartinov merged commit 875f071 into master May 1, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/cross_test_pretty_sets branch May 1, 2024 02:48
VenelinMartinov added a commit that referenced this pull request May 2, 2024
Related to #1762

Adds support for config mode in the rapid-generated schemas.

Stacked on #1908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants