Revert "Remove experimental flag for SkipDetailedDiff (#1893)" #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 60.24% 62.11% +1.86%
==========================================
Files 329 328 -1
Lines 44467 36983 -7484
==========================================
- Hits 26791 22972 -3819
+ Misses 16175 12511 -3664
+ Partials 1501 1500 -1 ☔ View full report in Codecov by Sentry. |
t0yv0
approved these changes
May 6, 2024
VenelinMartinov
added a commit
that referenced
this pull request
May 8, 2024
VenelinMartinov
added a commit
that referenced
this pull request
May 8, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c57799f, reversing changes made to e71c1a6.
reverts #1893
We have some downstream failures:
https://github.com/pulumi/pulumi-azure/actions/runs/8945276805/job/24576271881?pr=2001
https://github.com/pulumi/pulumi-github/actions/runs/8945161556/job/24576285007?pr=652
Some opened issues which look like prerequisites:
pulumi/pulumi-azure#1421 (related to the failure above)
pulumi/pulumi-confluentcloud#264 (we don't have credentials here, so likely why it did not produce a downstream failure)
Anton also noted some issues with SkipDetailedDiff in AWS, so this change seems much less risky than initially though.