Fix pf tag parent #1930
Merged
Fix pf tag parent #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
+ Coverage 60.24% 60.32% +0.07%
==========================================
Files 329 329
Lines 44467 44412 -55
==========================================
Hits 26791 26791
+ Misses 16175 16120 -55
Partials 1501 1501 ☔ View full report in Codecov by Sentry. |
t0yv0
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1926
Correctly parent master to the last pf release in order for go to increment pre-release versions correctly.
This works: pulumi/pulumi-tls#503 - this is the hash from this PR.
This is before this PR: pulumi/pulumi-tls@c039dbf#diff-cd249c062d77b4d6a5621756423850d0708ffbe4aae554ce33cdc5b908b0ee39
Notice that the pf pre-release version was
v0.33.1-0.20240503212316-40b530845390which, when competing withv0.34.0resolved tov0.34.0, even thoughv0.33.1-0.20240503212316-40b530845390is newer.Now the version is correctly labeled as post-0.34.0:
v0.34.1-0.20240506185132-7e489cef7052