Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross test add depth to prop names #1931

Merged
merged 1 commit into from
May 9, 2024

Conversation

VenelinMartinov
Copy link
Contributor

This makes the schemas a bit more legible.

It's probably enough for now, we should make the property names actually unique later.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.51%. Comparing base (012ac65) to head (8904bcc).

Files Patch % Lines
pkg/tests/cross-tests/rapid_tv_gen.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1931   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files         329      329           
  Lines       44477    44477           
=======================================
  Hits        26917    26917           
- Misses      16050    16051    +1     
+ Partials     1510     1509    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov merged commit fa1796a into master May 9, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/cross_tests_unique_prop_names branch May 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants