Fix proposed new unknown blocks #2060
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
- Coverage 61.57% 61.20% -0.37%
==========================================
Files 334 337 +3
Lines 44955 45177 +222
==========================================
- Hits 27681 27651 -30
- Misses 15750 16005 +255
+ Partials 1524 1521 -3 ☔ View full report in Codecov by Sentry. |
| @@ -69,7 +69,10 @@ func PlannedDataResourceObject(schema *configschema.Block, config cty.Value) cty | |||
| } | |||
|
|
|||
| func proposedNew(schema *configschema.Block, prior, config cty.Value) cty.Value { | |||
| if config.IsNull() || !config.IsKnown() { | |||
| if !config.IsKnown() { | |||
There was a problem hiding this comment.
This file is marked with:
// Code copied from https://github.com/hashicorp/terraform.git by go generate; DO NOT EDIT.
Are you sure this change brings the overall system closer to TF Behavior? Can we place it outside this file to keep it vendored?
There was a problem hiding this comment.
Ah I see, I see, I'd guess this branch is never even hit in TF. So it's fine to edit. If you can place the edit at the call site of ObjChange not this file itself it can be easier to keep up with vendoring. Thank you!
There was a problem hiding this comment.
The function is recursive, so we can't do that easily. We could add a reconstruction step after this function which goes and recovers unknowns where they were discarded but I feel like this is better.
I'll see if there's a newer version of this upstream.
There was a problem hiding this comment.
Yup, updating the objchange copy did fix the issue.
| const terraformRepo = "https://github.com/hashicorp/terraform.git" | ||
| const terraformVer = "v1.3.9" | ||
| const terraformRepo = "https://github.com/opentofu/opentofu.git" | ||
| const terraformVer = "v1.7.2" |
|
The objchange update is amazing. This can be a very big change now may trip up downstream tests, though probably a good one. Great find!! |
|
Well, this passes for me locally... Had to merge master - apparently CI does not run on your branch but on the merged result. |
This updates our
objchangealgorithm with the newest one from the OpenTofu repo. This fixes an issue with the way unknown sets are presented to TF.fixes #1951