Dynamic Bridged Providers: Plugin Aquisition #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
force-pushed
the
iwahbe/dynamic-provider-loader
branch
2 times, most recently
from
e647f7b
to
eb21de6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2080 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 339 340 +1
Lines 45132 45143 +11
=======================================
+ Hits 27627 27636 +9
- Misses 15985 15987 +2
Partials 1520 1520 ☔ View full report in Codecov by Sentry. |
t0yv0
reviewed
Jun 12, 2024
t0yv0
reviewed
Jun 12, 2024
t0yv0
reviewed
Jun 12, 2024
| slog.Info("Found v5 provider.. upgrading to v6") | ||
|
|
||
| v6, err := tf5to6server.UpgradeServer(ctx, func() tfprotov5.ProviderServer { | ||
| return v5shim.New(tfplugin5.NewProviderClient(rpcClient.(*plugin.GRPCClient).Conn)) |
There was a problem hiding this comment.
This is interesting. Indeed looks like protobuf doesn't make this translation easy though it should be entirely mechanical.
There was a problem hiding this comment.
I see, this is actually one level up from raw protos. And something like this https://github.com/hashicorp/terraform-plugin-go/blob/v0.23.0/tfprotov5/internal/fromproto/provider.go#L31 is internal unfortunately.
t0yv0
approved these changes
Jun 12, 2024
Broken off from #1973 for easier review.
iwahbe
force-pushed
the
iwahbe/dynamic-provider-loader
branch
from
eb21de6
to
f801aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from #1973 for easier review.
Fixes https://github.com/pulumi/home/issues/3409