Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method: runtypes.{Resources,DataSources}.Diagnostic #2106

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jun 18, 2024

This method is never called in our code.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (91c66e4) to head (47fa174).

Files Patch % Lines
pf/internal/pfutils/datasources.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files         350      350           
  Lines       45711    45704    -7     
=======================================
- Hits        27768    27765    -3     
+ Misses      16424    16420    -4     
  Partials     1519     1519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe merged commit fec08a7 into master Jun 24, 2024
11 checks passed
@iwahbe iwahbe deleted the iwahbe/remove-unused-function branch June 24, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants