Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pulumi to v3.120.0 (simply) #2112

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jun 22, 2024

Given the difficulties associated with #2109 and #2099, I thought we should try doing the minimal work necessary to upgrade. We can then iterate from here without falling further behind on pulumi/pulumi.

Update 1: I believe that TestCollectionsNullEmptyRefreshClean continues to fail. This is unfortunate but not shocking given that it is an integration test on refresh, and we changed the behavior of refresh in pulumi/pulumi v3.120.0. It looks like that is the only test failing. make -C pf test runs cleanly.

Update 2: The test resolves when you upgrade the local CLI for pulumi to v3.120.0.

@iwahbe iwahbe force-pushed the iwahbe/upgrade-pulumi-to-v3.120.0-simple branch from 71a2522 to ad64817 Compare June 22, 2024 00:51
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 8.82353% with 93 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (4cecc87) to head (ad64817).

Files Patch % Lines
pf/internal/plugin/provider_context.go 0.00% 61 Missing ⚠️
pkg/tfgen/pluginHost.go 19.04% 17 Missing ⚠️
pkg/tfbridge/provider.go 27.77% 13 Missing ⚠️
pf/tfbridge/provider.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   60.74%   60.68%   -0.06%     
==========================================
  Files         350      350              
  Lines       45704    45741      +37     
==========================================
- Hits        27761    27759       -2     
- Misses      16425    16463      +38     
- Partials     1518     1519       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe merged commit cb48761 into master Jun 22, 2024
11 checks passed
@iwahbe iwahbe deleted the iwahbe/upgrade-pulumi-to-v3.120.0-simple branch June 22, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants