Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor schematized types #266

Merged
merged 5 commits into from
Sep 16, 2020
Merged

Refactor schematized types #266

merged 5 commits into from
Sep 16, 2020
+42 −34

Conversation

komalali
Copy link
Member

@komalali komalali commented Sep 15, 2020 •
edited

Proposed changes

Expanding ObjectTypeSpec to ComplexTypeSpec to expand the types section in the schema to accommodate enums.

Related

@komalali komalali mentioned this pull request Sep 15, 2020
Merged
@komalali
Copy link
Member Author

komalali commented Sep 15, 2020 •
edited

Note: Some downstream tests are broken due to the API break from #264.

I've tested the changes manually in random and the AWS downstream changes are linked below.

@komalali komalali changed the title Rename ObjectTypeSpec to ComplexTypeSpec Refactor schematized types Sep 16, 2020
@github-actions
Copy link

Diff for pulumi-aws with merge commit 914bf01

@komalali komalali merged commit 1676c22 into master Sep 16, 2020
@komalali komalali deleted the komalali/update-schema-gen branch September 16, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

@stack72 stack72 Awaiting requested review from stack72

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@komalali @pgavlin